Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes commit SHA in docs/go.sum #4315

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fixes commit SHA in docs/go.sum #4315

merged 1 commit into from
Sep 4, 2023

Conversation

jputrino
Copy link
Contributor

@jputrino jputrino commented Sep 1, 2023

Proposed changes

  • The release tag for nginx-hugo-theme v0.37.0 was deleted and re-created, which caused hugo to return a security error when downloading the theme. Because I know the DocOps team deleted and re-created the release, I replaced the old SHA in the go.sum file with the correct, newer one to resolve the issue.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

- The release tag for nginx-hugo-theme v0.37.0 was deleted and re-created, which caused hugo to return a security error when downloading the theme. Because I know the DocOps team deleted and re-created the release, I replaced the old SHA in the go.sum file with the correct, newer one to resolve the issue.
@jputrino jputrino requested review from a team as code owners September 1, 2023 18:47
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #4315 (3fdd3d2) into main (1342aa6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4315      +/-   ##
==========================================
- Coverage   52.19%   52.17%   -0.03%     
==========================================
  Files          59       59              
  Lines       16930    16930              
==========================================
- Hits         8837     8833       -4     
- Misses       7796     7798       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel merged commit 665ef5f into main Sep 4, 2023
@vepatel vepatel deleted the fix-hugo-builds branch September 4, 2023 07:59
@lucacome lucacome added the documentation Pull requests/issues for documentation label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants