Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example spec comment for GlobalConfiguration in helm values.yaml #4285

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Aug 23, 2023

Proposed changes

This change updates the example comment for the controller.globalConfiguration.spec field in deployments/helm-chart/values.yaml to provide more clarity on the exact format for adding listeners.

Resolves #4284

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested a review from a team as a code owner August 23, 2023 12:02
@github-actions github-actions bot added chore Pull requests for routine tasks helm_chart Pull requests that update the Helm Chart labels Aug 23, 2023
@shaun-nx shaun-nx changed the title Chore/helm values gc comment Update example spec comment for GlobalConfiguration in helm values.yaml Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4285 (550ba66) into main (05ba01b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4285      +/-   ##
==========================================
- Coverage   52.19%   52.17%   -0.03%     
==========================================
  Files          59       59              
  Lines       16930    16930              
==========================================
- Hits         8837     8833       -4     
- Misses       7796     7798       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx requested a review from brianehlert August 24, 2023 09:41
@shaun-nx shaun-nx merged commit 75b6d44 into main Aug 28, 2023
@shaun-nx shaun-nx deleted the chore/helm-values-gc-comment branch August 28, 2023 10:08
@lucacome lucacome removed the helm_chart Pull requests that update the Helm Chart label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update example spec comment for GlobalConfiguration in helm values.yaml
6 participants