-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom listener controls to VirtualServer #4271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d39ac81.
This reverts commit 8f2738d.
for more information, see https://pre-commit.ci
github-actions
bot
added
documentation
Pull requests/issues for documentation
enhancement
Pull requests for new features/feature enhancements
labels
Aug 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #4271 +/- ##
==========================================
+ Coverage 51.97% 52.17% +0.19%
==========================================
Files 59 59
Lines 16762 16930 +168
==========================================
+ Hits 8712 8833 +121
- Misses 7753 7798 +45
- Partials 297 299 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shaun-nx
changed the title
Feat/custom listeners
Add custom listener controls to VirtualServer
Aug 22, 2023
vepatel
reviewed
Aug 23, 2023
jjngx
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 great stuff!
vepatel
approved these changes
Aug 24, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
enhancement
Pull requests for new features/feature enhancements
helm_chart
Pull requests that update the Helm Chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issue: #4094
Related discussion: #3724
This change updates both VirtualServer and GlobalConfiguration resources to enable VirtualServers to specify custom HTTP and HTTPS listener ports.
Example VirtualServer YAML:
Example GlobalConfiguration YAML:
When performing requests to the example VirtualServer, all HTTP based requests will use port 8083 and HTTPS based requests will use 8443.
Checklist
Before creating a PR, run through this checklist and mark each as complete.