Make containerPort and hostPort customizable #4252
Merged
+63
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #4252 +/- ##
=======================================
Coverage 51.97% 51.97%
=======================================
Files 59 59
Lines 16762 16762
=======================================
Hits 8712 8712
Misses 7753 7753
Partials 297 297 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jjngx
approved these changes
Aug 17, 2023
shaun-nx
approved these changes
Aug 18, 2023
haywoodsh
approved these changes
Aug 18, 2023
lucacome
removed
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Makes
containerPortandhostPortcustomizable in the Helm Chart.Fixes #3613
Fixes nginxinc/nginx-ingress-helm-operator#143
Closes #3655