Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go docs for path-regex #4248

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Update Go docs for path-regex #4248

merged 2 commits into from
Aug 16, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Aug 16, 2023

Proposed changes

This PR updates Go docs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner August 16, 2023 09:24
@jjngx jjngx added the documentation Pull requests/issues for documentation label Aug 16, 2023
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4248 (5f72b58) into main (da221ce) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4248      +/-   ##
==========================================
- Coverage   51.96%   51.95%   -0.02%     
==========================================
  Files          59       59              
  Lines       16762    16762              
==========================================
- Hits         8710     8708       -2     
- Misses       7753     7755       +2     
  Partials      299      299              
Files Changed Coverage Δ
internal/configs/version1/template_helper.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot removed the documentation Pull requests/issues for documentation label Aug 16, 2023
@jjngx jjngx merged commit 63f7f2f into main Aug 16, 2023
@jjngx jjngx deleted the feat/path-regex branch August 16, 2023 12:05
@lucacome lucacome added chore Pull requests for routine tasks and removed enhancement Pull requests for new features/feature enhancements labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants