Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for path-regex annotation in Ingress Master-Minion #4200

Merged
merged 12 commits into from
Aug 11, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Aug 9, 2023

Proposed changes

This PR adds support for setting up nginx.org/path-regex annotations
for Ingress and Ingress Master - Minion setup.

When this PR is merged, users will be able:

  • Configure nginx.org/path-regex annotations on Minions and Master Ingress independently.
  • Configure nginx.org/path-regex annotations (regex modifiers) case_sensitive, case_insensitive and exact independently on each minion or master

Annotations set on Minions take higher priority over annotations set on Master.
PR with documentation updates will follow once this one is merged with the main branch.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Sorry, something went wrong.

@jjngx jjngx requested a review from a team as a code owner August 9, 2023 15:41
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Aug 9, 2023
@jjngx jjngx requested a review from haywoodsh August 9, 2023 15:42
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@jjngx jjngx linked an issue Aug 9, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #4200 (47ee717) into main (514b275) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4200   +/-   ##
=======================================
  Coverage   51.96%   51.96%           
=======================================
  Files          59       59           
  Lines       16743    16753   +10     
=======================================
+ Hits         8700     8706    +6     
- Misses       7746     7748    +2     
- Partials      297      299    +2     
Files Changed Coverage Δ
internal/configs/version1/template_helper.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff Jakub. A lot of this new testing code is going to make template testing much easier going forward 🚀

@jjngx jjngx requested a review from a team August 10, 2023 12:40
@jjngx jjngx merged commit cace410 into main Aug 11, 2023
@jjngx jjngx deleted the feat/path-regex branch August 11, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support regex path for Ingress resource (minion - master)
3 participants