-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for path-regex annotation in Ingress Master-Minion #4200
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
Codecov Report
@@ Coverage Diff @@
## main #4200 +/- ##
=======================================
Coverage 51.96% 51.96%
=======================================
Files 59 59
Lines 16743 16753 +10
=======================================
+ Hits 8700 8706 +6
- Misses 7746 7748 +2
- Partials 297 299 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff Jakub. A lot of this new testing code is going to make template testing much easier going forward 🚀
Proposed changes
This PR adds support for setting up nginx.org/path-regex annotations
for Ingress and Ingress Master - Minion setup.
When this PR is merged, users will be able:
nginx.org/path-regex
annotations on Minions and Master Ingress independently.nginx.org/path-regex
annotations (regex modifiers)case_sensitive
,case_insensitive
andexact
independently on each minion or masterAnnotations set on Minions take higher priority over annotations set on Master.
PR with documentation updates will follow once this one is merged with the main branch.
Checklist
Before creating a PR, run through this checklist and mark each as complete.