Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGINX Ingress with Linkerd virtualserver example #4135

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

jasonwilliams14
Copy link
Contributor

Proposed changes

This PR adds an example virtualserver resource showing how to configure NGINX Ingress controller when using Linkerd service mesh.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jasonwilliams14 jasonwilliams14 requested a review from a team as a code owner July 21, 2023 03:13
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 21, 2023
@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #4135 (fb3d011) into main (d59d37f) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4135      +/-   ##
==========================================
+ Coverage   51.84%   51.87%   +0.02%     
==========================================
  Files          59       59              
  Lines       16710    16710              
==========================================
+ Hits         8664     8668       +4     
+ Misses       7747     7745       -2     
+ Partials      299      297       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx merged commit 9a3a954 into main Jul 21, 2023
@jjngx jjngx deleted the docs/kic-linkerd-example branch July 21, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants