Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting for markdown files #4133

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Add linting for markdown files #4133

merged 1 commit into from
Jul 25, 2023

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jul 21, 2023

Proposed changes

Adds markdownlint step to pre-commit. All markdown files except the .github files (and docs for now) will be linted before every commit.
Markdownlint will attempt to fix the linting errors and will report any errors it cannot fix.
Linting rules are in the .markdownlint-cli2.yaml file in the root of the repo.
For details on the linting rules, see: DavidAnson/markdownlint@main/doc/Rules.md

@lucacome lucacome self-assigned this Jul 21, 2023
@lucacome lucacome requested a review from a team as a code owner July 21, 2023 01:22
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests labels Jul 21, 2023
@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

.github/workflows/lint.yml

@lucacome lucacome force-pushed the chore/add-markdown-lint branch from 8097f59 to c15fd26 Compare July 21, 2023 01:26
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #4133 (5944690) into main (1668e8b) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4133      +/-   ##
==========================================
+ Coverage   51.84%   51.87%   +0.02%     
==========================================
  Files          59       59              
  Lines       16710    16710              
==========================================
+ Hits         8664     8668       +4     
+ Misses       7747     7745       -2     
+ Partials      299      297       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome force-pushed the chore/add-markdown-lint branch from c15fd26 to 5944690 Compare July 25, 2023 00:19
@lucacome lucacome enabled auto-merge (squash) July 25, 2023 00:22
@lucacome lucacome merged commit 8584737 into main Jul 25, 2023
@lucacome lucacome deleted the chore/add-markdown-lint branch July 25, 2023 00:28
@lucacome lucacome removed the helm_chart Pull requests that update the Helm Chart label Jul 25, 2023
@lucacome lucacome removed the tests Pull requests that update tests label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants