-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path-regex annotation for ingress #4127
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
Codecov Report
@@ Coverage Diff @@
## main #4127 +/- ##
==========================================
+ Coverage 51.84% 51.91% +0.06%
==========================================
Files 59 59
Lines 16710 16735 +25
==========================================
+ Hits 8664 8688 +24
- Misses 7747 7749 +2
+ Partials 299 298 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
docs/content/configuration/ingress-resources/advanced-configuration-with-annotations.md
Outdated
Show resolved
Hide resolved
…ation-with-annotations.md Co-authored-by: Shaun <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Shaun <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few ideas/questions for review.
docs/content/configuration/ingress-resources/advanced-configuration-with-annotations.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed changes
This PR adds support for path-regex annotation for Ingress.
Users can define paths (locations) using one of the following regex annotations:
Example ingress resource:
Checklist
Before creating a PR, run through this checklist and mark each as complete.