Update installation-with-manifests.md #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a typo in the GlobalConfiguration CRD step. Signed-off-by: Jodie Putrino <[email protected]>
github-actions
bot
added
the
documentation
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
aknot242
approved these changes
Jul 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #4090 +/- ##
==========================================
+ Coverage 51.84% 51.87% +0.02%
==========================================
Files 59 59
Lines 16710 16710
==========================================
+ Hits 8664 8668 +4
+ Misses 7747 7745 -2
+ Partials 299 297 -2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jjngx
approved these changes
Jul 11, 2023
vepatel
approved these changes
Jul 12, 2023
ADubhlaoich
approved these changes
Jul 12, 2023
haywoodsh
approved these changes
Jul 12, 2023
ADubhlaoich
added a commit
that referenced
this pull request
Jul 13, 2023
Fixes a typo in the GlobalConfiguration CRD step. Signed-off-by: Jodie Putrino <[email protected]> Co-authored-by: Alan Dooley <[email protected]>
jjngx
pushed a commit
that referenced
this pull request
Jul 13, 2023
…#4097) This commit includes two small changes: the first is removing a line from the Hugo configuration file that was preventing the appropriate styling to occur for code blocks. The second is to fix an incorrectly closed table in the technical specifications page. The largest change is reformatting of the Installation with Manifests page. Multiple sections of the page now have horizontal lines to separate them visually: many instances of notes were replaced with the formal Hugo shortcode for notes. Indentation was also fixed in multiple places, with subheadings being used to create explicit flow where previously it was implicit. Finally, there are multiple instances of nouns being fixed, as well as certain portions of text being rephrased for clarity or conciseness. Signed-off-by: Jodie Putrino <[email protected]> --------- Signed-off-by: Jodie Putrino <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jodie Putrino <[email protected]> * Update installation-with-manifests.md (#4090) Fixes a typo in the GlobalConfiguration CRD step. Signed-off-by: Jodie Putrino <[email protected]> Co-authored-by: Alan Dooley <[email protected]> --------- Signed-off-by: Jodie Putrino <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jodie Putrino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a typo in the GlobalConfiguration CRD step.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.