Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if API is available in Helm Chart #4070

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Check if API is available in Helm Chart #4070

merged 2 commits into from
Jul 17, 2023

Conversation

lucacome
Copy link
Member

Proposed changes

Checks if autoscaling/v2 is available rather than checking a specific version of kubernetes

Fixes #4069

@lucacome
Check if API is available in Helm Chart
ee6d0db 
Checks if autoscaling/v2 is available rather than checking a specific
version of kubernetes
@lucacome lucacome self-assigned this Jun 30, 2023
@lucacome lucacome requested a review from a team as a code owner June 30, 2023 15:44
@github-actions github-actions bot added chore Pull requests for routine tasks helm_chart Pull requests that update the Helm Chart labels Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 30, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #4070 (6e158b1) into main (8ea6f2a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4070   +/-   ##
=======================================
  Coverage   51.87%   51.87%           
=======================================
  Files          59       59           
  Lines       16710    16710           
=======================================
  Hits         8668     8668           
  Misses       7745     7745           
  Partials      297      297

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomasohaodha tomasohaodha self-requested a review July 6, 2023 13:09
tomasohaodha
tomasohaodha previously requested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@tomasohaodha tomasohaodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing @lucacome if not already done so

jasonwilliams14
jasonwilliams14 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick test and it worked in my lab tests.

@shaun-nx shaun-nx requested a review from tomasohaodha July 17, 2023 10:04
@jjngx jjngx dismissed tomasohaodha’s stale review July 17, 2023 10:09

tested by Jason (see above)

@vepatel vepatel mentioned this pull request Jul 17, 2023
Closed
@lucacome lucacome enabled auto-merge (squash) July 17, 2023 22:01
@lucacome lucacome merged commit 306cf5a into main Jul 17, 2023
@lucacome lucacome deleted the chore/helm-check-api branch July 17, 2023 22:10
@AlessioCasco AlessioCasco mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@tomasohaodha tomasohaodha tomasohaodha approved these changes

@jasonwilliams14 jasonwilliams14 jasonwilliams14 approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart HPA condition
5 participants
@lucacome @haywoodsh @jasonwilliams14 @tomasohaodha @jjngx