Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clusterIP to service if specified in values #4058

Merged
merged 7 commits into from
Aug 16, 2023

Conversation

EutiziStefano
Copy link
Contributor

Proposed changes

If you need to specify a fixed clusterip, add it to the values and it will be used in the service manifest.

Opened issue: #4057

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [ X] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • [X ] I have updated necessary documentation
  • I have rebased my branch onto main
  • [X ] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Signed-off-by: EutiziStefano <[email protected]>
Signed-off-by: EutiziStefano <[email protected]>
@EutiziStefano EutiziStefano requested a review from a team as a code owner June 26, 2023 08:54
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Jun 26, 2023
@brianehlert brianehlert linked an issue Jun 26, 2023 that may be closed by this pull request
@brianehlert brianehlert added the enhancement Pull requests for new features/feature enhancements label Jun 28, 2023
@vepatel
Copy link
Contributor

vepatel commented Aug 15, 2023

@EutiziStefano would you like to make the suggested change?

@github-actions github-actions bot removed the enhancement Pull requests for new features/feature enhancements label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #4058 (3c2e7ec) into main (5a6a3d2) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4058      +/-   ##
==========================================
- Coverage   51.97%   51.95%   -0.03%     
==========================================
  Files          59       59              
  Lines       16762    16762              
==========================================
- Hits         8712     8708       -4     
- Misses       7753     7755       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel
Copy link
Contributor

vepatel commented Aug 16, 2023

Thanks @lucacome

@vepatel vepatel enabled auto-merge (squash) August 16, 2023 09:52
@vepatel vepatel merged commit da221ce into nginx:main Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding kubernetes service clusterIP to the helm chart
4 participants