-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FIPS to the list of images #4048
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
Codecov Report
@@ Coverage Diff @@
## main #4048 +/- ##
==========================================
+ Coverage 51.83% 51.87% +0.03%
==========================================
Files 59 59
Lines 16705 16705
==========================================
+ Hits 8659 8665 +6
+ Misses 7747 7743 -4
+ Partials 299 297 -2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, made some very small suggestions that aren't blockers.
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Luca Comellini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Proposed changes
Adds FIPS to the list of images and Docker commands. Also fixes names and formatting.