Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add document to tutorial section for configuring the default oidc implementation #4022

Merged
merged 8 commits into from
Jun 20, 2023
Merged

Add document to tutorial section for configuring the default oidc implementation #4022

merged 8 commits into from
Jun 20, 2023

Conversation

shaun-nx
Copy link
Contributor

Proposed changes

This PR adds a new document to the tutorial section.
This document shows how to customise and overwrite the contents of the oidc.conf file using a ConfigMap.

@shaun-nx shaun-nx requested a review from a team as a code owner June 19, 2023 15:56
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 19, 2023
@github-actions
Copy link

github-actions bot commented Jun 19, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@shaun-nx shaun-nx requested a review from haywoodsh June 19, 2023 15:57
@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited
Loading

Codecov Report

Merging #4022 (8a4cbd8) into main (4a328ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4022   +/-   ##
=======================================
  Coverage   51.85%   51.85%           
=======================================
  Files          59       59           
  Lines       16705    16705           
=======================================
  Hits         8663     8663           
  Misses       7745     7745           
  Partials      297      297

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ADubhlaoich
ADubhlaoich approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads went overall, added a few edit suggestions.

ADubhlaoich
ADubhlaoich approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I made a number of suggestions.

The title & description feel odd for the actual document it's covering, since this seems to have little to do with OSM.

@shaun-nx shaun-nx added this to the v3.2.0 milestone Jun 20, 2023
@shaun-nx shaun-nx merged commit f6f0715 into main Jun 20, 2023
@shaun-nx shaun-nx deleted the oidcConfigMap branch June 20, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@jjngx jjngx jjngx approved these changes

@vepatel vepatel vepatel approved these changes

@brianehlert brianehlert Awaiting requested review from brianehlert

@jasonwilliams14 jasonwilliams14 Awaiting requested review from jasonwilliams14

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shaun-nx @ADubhlaoich @vepatel @jjngx