Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Makefile #4020

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Cleanup Makefile #4020

merged 3 commits into from
Jun 21, 2023

Conversation

lucacome
Copy link
Member

Proposed changes

Changes:

  • Removes old targets that were deprecated, 14 months have passed now
  • Removes GIT_COMMIT as it's been part of the build info for a while
  • Fixes formatting and wording for some targets

@lucacome
Cleanup Makefile
e09bab9 
Changes:
- Removes old targets that were deprecated, 14 months have passed now
- Removes GIT_COMMIT as it's been part of the build info for a while
- Fixes formatting and wording for some targets
@lucacome lucacome self-assigned this Jun 16, 2023
@lucacome lucacome requested a review from a team as a code owner June 16, 2023 17:54
@github-actions
Copy link

github-actions bot commented Jun 16, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023 •
edited
Loading

Codecov Report

Merging #4020 (192ad17) into main (9840615) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4020      +/-   ##
==========================================
- Coverage   51.87%   51.85%   -0.02%     
==========================================
  Files          59       59              
  Lines       16705    16705              
==========================================
- Hits         8665     8663       -2     
- Misses       7743     7745       +2     
  Partials      297      297

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shaun-nx
shaun-nx requested changes Jun 19, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@lucacome @shaun-nx
Update Makefile
2aef420 
Co-authored-by: Shaun <[email protected]>
Signed-off-by: Luca Comellini <[email protected]>
@lucacome lucacome requested review from shaun-nx and a team June 20, 2023 16:01
@lucacome lucacome added this to the v3.2.0 milestone Jun 20, 2023
jjngx
jjngx approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@shaun-nx shaun-nx self-requested a review June 21, 2023 13:46
@lucacome lucacome merged commit 78e2a66 into main Jun 21, 2023
@lucacome lucacome deleted the chore/cleanup-makefile branch June 21, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx shaun-nx approved these changes

@jjngx jjngx jjngx approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @jjngx @shaun-nx