Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the SameSite sticky cookie attribute #4001

Merged
merged 11 commits into from
Jun 19, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Jun 14, 2023

Proposed changes

This PR adds support for the SameSite attribute for session (sticky) cookies.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner June 14, 2023 14:35
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart labels Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #4001 (b2518a9) into main (439ad79) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4001      +/-   ##
==========================================
+ Coverage   51.84%   51.85%   +0.01%     
==========================================
  Files          59       59              
  Lines       16697    16705       +8     
==========================================
+ Hits         8657     8663       +6     
- Misses       7743     7745       +2     
  Partials      297      297              
Impacted Files Coverage Δ
internal/configs/version2/http.go 0.00% <ø> (ø)
internal/configs/version2/template_helper.go 75.00% <100.00%> (+5.00%) ⬆️
internal/configs/virtualserver.go 94.55% <100.00%> (+<0.01%) ⬆️
pkg/apis/configuration/validation/virtualserver.go 93.98% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the tests Pull requests that update tests label Jun 15, 2023
@jjngx jjngx requested review from haywoodsh, shaun-nx and vepatel June 15, 2023 15:27
@github-actions
Copy link

github-actions bot commented Jun 16, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@jjngx jjngx added this to the v3.2.0 milestone Jun 16, 2023
@jjngx jjngx requested a review from a team June 16, 2023 12:27
@jjngx jjngx merged commit 1aaf6df into main Jun 19, 2023
@jjngx jjngx deleted the feat/sessioncookie-samesite branch June 19, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants