Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openid-connect.js #3995

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Update openid-connect.js #3995

merged 5 commits into from
Jun 15, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jun 13, 2023

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Verified

This commit was signed with the committer’s verified signature.
jjngx Jakub Jarosz
@vepatel vepatel requested review from haywoodsh and shaun-nx June 13, 2023 14:39
@vepatel vepatel requested a review from a team as a code owner June 13, 2023 14:39
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jun 13, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
for more information, see https://pre-commit.ci
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #3995 (e3e4660) into main (aaec464) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head e3e4660 differs from pull request most recent head 0583636. Consider uploading reports for the commit 0583636 to get more accurate results

@@            Coverage Diff             @@
##             main    #3995      +/-   ##
==========================================
+ Coverage   51.81%   51.83%   +0.02%     
==========================================
  Files          59       59              
  Lines       16697    16697              
==========================================
+ Hits         8651     8655       +4     
+ Misses       7747     7745       -2     
+ Partials      299      297       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

vepatel added 2 commits June 13, 2023 17:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vepatel vepatel merged commit b09fd72 into main Jun 15, 2023
@vepatel vepatel deleted the feature/sync-openid-connect branch June 15, 2023 10:16
@shaun-nx shaun-nx added this to the v3.2.0 milestone Jun 20, 2023
@lucacome lucacome added chore Pull requests for routine tasks and removed enhancement Pull requests for new features/feature enhancements labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants