NGINX Ingress with Linkerd guide #3993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
github-actions
bot
added
the
documentation
Codecov Report
@@ Coverage Diff @@
## main #3993 +/- ##
==========================================
+ Coverage 51.81% 51.83% +0.02%
==========================================
Files 59 59
Lines 16697 16705 +8
==========================================
+ Hits 8651 8659 +8
Misses 7747 7747
Partials 299 299 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shaun-nx
requested review from
ADubhlaoich,
haywoodsh,
vepatel,
jjngx and
shaun-nx
shaun-nx
reviewed
Jun 20, 2023
shaun-nx
reviewed
Jun 20, 2023
shaun-nx
reviewed
Jun 20, 2023
shaun-nx
reviewed
Jun 20, 2023
shaun-nx
reviewed
Jun 20, 2023
shaun-nx
reviewed
Jun 20, 2023
shaun-nx
reviewed
Jun 20, 2023
shaun-nx
reviewed
Jun 20, 2023
This commit makes large structural changes to the tutorial to integrate Linkerd with NGINX Ingress Controller first by adjusting the information architecture to more closely match that of other NGINX products, then by creating subsections for instructions based on the two main use cases. There is additional work to be completed in order to make this page more complete, as it is lacking an example for a custom resource as part of an integrated installation, and the examples are inconsistent.
for more information, see https://pre-commit.ci
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
ADubhlaoich
requested changes
Jun 22, 2023
There was a problem hiding this comment.
I have pushed a large number of changes to this tutorial - @jasonwilliams14 , you'll need to review this for accuracy and also to add what I think is a missing example of a CRD for Linkerd. In the original page it's mentioned but doesn't seem to have much detail compared to Helm.
Signed-off-by: Jason Williams - NGIИX <[email protected]>
lucacome
approved these changes
Jun 23, 2023
Co-authored-by: Luca Comellini <[email protected]> Signed-off-by: Jason Williams - NGIИX <[email protected]>
lucacome
changed the title
lucacome
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
NGINX Ingress controller with Linkerd
Checklist
Before creating a PR, run through this checklist and mark each as complete.