Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for ready endpoints #3983

Merged
merged 23 commits into from
Jul 3, 2023
Merged

Check for ready endpoints #3983

merged 23 commits into from
Jul 3, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Jun 12, 2023

Proposed changes

Refactor long nested for loops into functions to emphasise 3 steps:

  1. filtering endpoint slices for provided port
  2. filtering endpoints that match status ready
  3. calculating pod endpoints

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
jjngx Jakub Jarosz
@github-actions github-actions bot added the tests Pull requests that update tests label Jun 12, 2023
@jjngx jjngx requested review from shaun-nx and haywoodsh June 12, 2023 10:19
@jjngx jjngx marked this pull request as ready for review June 12, 2023 10:20
@jjngx jjngx requested a review from a team as a code owner June 12, 2023 10:20
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #3983 (aaf2c48) into main (f3abd93) will decrease coverage by 0.03%.
The diff coverage is 91.37%.

@@            Coverage Diff             @@
##             main    #3983      +/-   ##
==========================================
- Coverage   51.87%   51.84%   -0.03%     
==========================================
  Files          59       59              
  Lines       16705    16710       +5     
==========================================
- Hits         8665     8664       -1     
- Misses       7743     7747       +4     
- Partials      297      299       +2     
Impacted Files Coverage Δ
internal/k8s/controller.go 12.11% <91.37%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx requested a review from ciarams87 June 12, 2023 10:25
@jjngx jjngx added change Pull requests that introduce a change chore Pull requests for routine tasks labels Jun 12, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot removed the chore Pull requests for routine tasks label Jun 13, 2023
jjngx added 4 commits June 13, 2023 22:47

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions
Copy link

github-actions bot commented Jun 16, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@jjngx jjngx added this to the v3.2.0 milestone Jun 16, 2023
jjngx added 3 commits June 16, 2023 13:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jjngx jjngx removed this from the v3.2.0 milestone Jun 19, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jjngx jjngx requested review from a team and pleshakov June 20, 2023 11:52
@brianehlert brianehlert added this to the v3.3.0 milestone Jun 20, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
jjngx added 7 commits June 20, 2023 17:47

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
jjngx and others added 2 commits June 28, 2023 21:14

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jjngx jjngx changed the title Refactor check for ready endpoints Check for ready endpoints Jun 28, 2023
jjngx and others added 2 commits July 3, 2023 13:39

Verified

This commit was signed with the committer’s verified signature.
jjngx Jakub Jarosz

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jjngx jjngx merged commit e2fea37 into main Jul 3, 2023
@jjngx jjngx deleted the tests/endpointslices branch July 3, 2023 13:55
@vepatel vepatel added chore Pull requests for routine tasks and removed change Pull requests that introduce a change labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants