Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme version, adjust weight of top level pages & sections #3979

Merged
merged 6 commits into from
Jun 19, 2023

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Jun 9, 2023

Proposed changes

This commit updates the documentation theme version: with the change, the "weight" frontmatter parameter for a handful of pages has also been adjusted.

Prior to this theme version, folders would not respect the weight frontmatter for the purposes of ordering page layout. This means that no matter what the value was, folders would always be at the top in the hierarchy.

With this change, that is no longer the case - and the adjustments to existing pages ensure that they adhere to the structure the documentation had previously.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit updates the documentation theme version: with the change,
the "weight" frontmatter parameter for a handful of pages has also been
adjusted.

Prior to this theme version, folders would not respect the weight
frontmatter for the purposes of ordering page layout. This means that no
matter what the value was, folders would always be at the top in the
hierarchy.

With this change, that is no longer the case - and the adjustments to
existing pages ensure that they adhere to the structure the
documentation had previously.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner June 9, 2023 12:23
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #3979 (767f150) into main (1aaf6df) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3979   +/-   ##
=======================================
  Coverage   51.83%   51.83%           
=======================================
  Files          59       59           
  Lines       16705    16705           
=======================================
  Hits         8659     8659           
  Misses       7747     7747           
  Partials      299      299           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

docs/go.mod

@shaun-nx shaun-nx merged commit 4a328ae into main Jun 19, 2023
@shaun-nx shaun-nx deleted the docs/update-theme branch June 19, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants