Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix links and product name usage in NAP WAF config guide #3972

Merged
merged 4 commits into from
Jun 20, 2023
Merged

fix links and product name usage in NAP WAF config guide #3972

merged 4 commits into from
Jun 20, 2023

Conversation

jputrino
Copy link
Contributor

@jputrino jputrino commented Jun 7, 2023 •
edited
Loading

Proposed changes

  • fixes broken links to NAP WAF docs
  • fixes product name usage for NIC and NAP WAF throughout the doc

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jputrino jputrino requested a review from a team as a code owner June 7, 2023 17:26
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Merging #3972 (5feb8e1) into main (f6f0715) will not change coverage.
The diff coverage is n/a.

❗ Current head 5feb8e1 differs from pull request most recent head 573a523. Consider uploading reports for the commit 573a523 to get more accurate results

@@           Coverage Diff           @@
##             main    #3972   +/-   ##
=======================================
  Coverage   51.85%   51.85%           
=======================================
  Files          59       59           
  Lines       16705    16705           
=======================================
  Hits         8663     8663           
  Misses       7745     7745           
  Partials      297      297

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jputrino
fix links and product name usage in NAP WAF config guide
bdf40fd 
- fixes broken links to NAP WAF docs
- fixes product name usage for NIC and NAP WAF throughout the doc

Signed-off-by: Jodie Putrino <[email protected]>
shaun-nx
shaun-nx approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ADubhlaoich
ADubhlaoich approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@brianehlert brianehlert added this to the v3.2.0 milestone Jun 20, 2023
@shaun-nx shaun-nx merged commit 7e38416 into main Jun 20, 2023
@shaun-nx shaun-nx deleted the jp-docops-1683 branch June 20, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx shaun-nx approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jputrino @ADubhlaoich @haywoodsh @shaun-nx @brianehlert