Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify validators #3909

Merged
merged 6 commits into from
May 19, 2023
Merged

Simplify validators #3909

merged 6 commits into from
May 19, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented May 17, 2023

Proposed changes

This PR simplifies validators.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner May 17, 2023 14:18
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 17, 2023
@jjngx jjngx requested review from ciarams87, haywoodsh and shaun-nx May 17, 2023 14:19
@jjngx jjngx added tests Pull requests that update tests chore Pull requests for routine tasks and removed chore Pull requests for routine tasks tests Pull requests that update tests labels May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #3909 (8286356) into main (4cba337) will decrease coverage by 0.13%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main    #3909      +/-   ##
==========================================
- Coverage   51.91%   51.79%   -0.13%     
==========================================
  Files          59       59              
  Lines       16742    16697      -45     
==========================================
- Hits         8692     8648      -44     
+ Misses       7750     7749       -1     
  Partials      300      300              
Impacted Files Coverage Δ
internal/k8s/validation.go 93.48% <94.73%> (-0.40%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx merged commit 8b96ed9 into main May 19, 2023
@jjngx jjngx deleted the chore/tests branch May 19, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants