Update JWT install guide #3884
Merged
Update JWT install guide #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3884 +/- ##
=======================================
Coverage 51.95% 51.95%
=======================================
Files 59 59
Lines 16762 16762
=======================================
Hits 8708 8708
Misses 7755 7755
Partials 299 299 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dreesf5
suggested changes
May 8, 2023
jasonwilliams14
force-pushed
the
docs/jwt-token-update
branch
from
70f3e5b to
cf62de5
Compare
dreesf5
reviewed
May 17, 2023
brianehlert
reviewed
May 18, 2023
dreesf5
previously requested changes
May 18, 2023
jasonwilliams14
force-pushed
the
docs/jwt-token-update
branch
2 times, most recently
from
06a10a5 to
fcb0a54
Compare
jasonwilliams14
force-pushed
the
docs/jwt-token-update
branch
from
b72a6a4 to
94ba7c2
Compare
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
This commit makes some large changes in the layout, gramma and overall phrasing of this installation guide. Many instances of the NGINX Ingress Controller's name were changed, and where possible, text was made more concise. Additionally, many links were added or renamed for explicit ease in finding or understanding the context related to an instruction.
ADubhlaoich
approved these changes
Jun 23, 2023
jasonwilliams14
force-pushed
the
docs/jwt-token-update
branch
from
8110d02 to
737f13c
Compare
jasonwilliams14
force-pushed
the
docs/jwt-token-update
branch
from
1f54f6c to
1c48879
Compare
jasonwilliams14
force-pushed
the
docs/jwt-token-update
branch
from
10adbff to
72d2957
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Jason Williams - NGIИX <[email protected]>
…s-ingress into docs/jwt-token-update
for more information, see https://pre-commit.ci
This branch has had multiple merge conflicts and force pushes, completely erasing a number of large changes to the page to the point of unintentionally removing entire sections. This commit takes the last known good working version and adds the changes back as a fresh new point for the branch.
ADubhlaoich
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
This PR should be re-reviewed for accuracy (@jasonwilliams14 & @dreesf5 ) but I am happy with the state of the writing now.
for more information, see https://pre-commit.ci
haywoodsh
approved these changes
Jul 12, 2023
Updated versions Signed-off-by: Jason Williams - NGIИX <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>
dreesf5
approved these changes
Aug 15, 2023
Signed-off-by: Jason Williams - NGIИX <[email protected]>
jasonwilliams14
added a commit
that referenced
this pull request
Aug 17, 2023
(cherry picked from commit 1cc4428)
lucacome
pushed a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is an update to the JWT token method to install NGINX Ingress controller, providing a more detailed walkthrough.
Checklist
Before creating a PR, run through this checklist and mark each as complete.