-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update official Ingress resource link #3864
Conversation
At some stage the official Kubernetes documentation changed their information architecture, leading to a broken link from the Overview page of the NGINX Ingress Controller documentation. There may be other instances of broken links from this change, which will be addressed as they are discovered.
@ADubhlaoich we don't use conventional commits. Can you please update your commit message, PR title and PR description following our guidelines? |
Codecov Report
@@ Coverage Diff @@
## main #3864 +/- ##
==========================================
- Coverage 52.40% 52.37% -0.03%
==========================================
Files 59 59
Lines 16925 16925
==========================================
- Hits 8869 8865 -4
- Misses 7759 7761 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I've adjusted the PR title to remove the conventional commit convention and will do the same for the commit itself, but could you elaborate on what else about it may be incorrect? The line length for subject and the body of the commit are both under 72 characters: there are no issues to reference as this PR comes directly from a piece of feedback reported on the website - unless the expectation is that a publicly-facing issue is supposed to be written purely for reference of the PR. |
Proposed changes
At some stage the official Kubernetes documentation changed their information architecture, leading to a broken link from the Overview page of the NGINX Ingress Controller documentation.
There may be other instances of broken links from this change, which will be addressed as they are discovered.
Checklist
Before creating a PR, run through this checklist and mark each as complete.