Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update official Ingress resource link #3864

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented May 4, 2023

Proposed changes

At some stage the official Kubernetes documentation changed their information architecture, leading to a broken link from the Overview page of the NGINX Ingress Controller documentation.

There may be other instances of broken links from this change, which will be addressed as they are discovered.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

At some stage the official Kubernetes documentation changed their
information architecture, leading to a broken link from the Overview
page of the NGINX Ingress Controller documentation.

There may be other instances of broken links from this change, which
will be addressed as they are discovered.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner May 4, 2023 14:33
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label May 4, 2023
@lucacome
Copy link
Member

lucacome commented May 5, 2023

@ADubhlaoich we don't use conventional commits. Can you please update your commit message, PR title and PR description following our guidelines?

@ADubhlaoich ADubhlaoich changed the title docs: Update official Ingress resource link Update official Ingress resource link May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #3864 (8672da2) into main (1407c3a) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3864      +/-   ##
==========================================
- Coverage   52.40%   52.37%   -0.03%     
==========================================
  Files          59       59              
  Lines       16925    16925              
==========================================
- Hits         8869     8865       -4     
- Misses       7759     7761       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ADubhlaoich
Copy link
Contributor Author

@ADubhlaoich we don't use conventional commits. Can you please update your commit message, PR title and PR description following our guidelines?

I've adjusted the PR title to remove the conventional commit convention and will do the same for the commit itself, but could you elaborate on what else about it may be incorrect?

The line length for subject and the body of the commit are both under 72 characters: there are no issues to reference as this PR comes directly from a piece of feedback reported on the website - unless the expectation is that a publicly-facing issue is supposed to be written purely for reference of the PR.

@tomasohaodha tomasohaodha self-requested a review May 8, 2023 16:00
@tomasohaodha tomasohaodha merged commit 1e92ba4 into main May 8, 2023
@tomasohaodha tomasohaodha deleted the docs/fix-ingress-link branch May 8, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants