Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase counter and add retries to jwks and mtls ingress tests #3861

Merged
merged 8 commits into from
May 4, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 4, 2023

Proposed changes

  • add retries and increase counter for ingress_mtls and jwksuri tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the tests Pull requests that update tests label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #3861 (ecdf34a) into main (a79415e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3861   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files          59       59           
  Lines       16931    16931           
=======================================
  Hits         8871     8871           
  Misses       7761     7761           
  Partials      299      299           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel marked this pull request as ready for review May 4, 2023 13:40
@vepatel vepatel requested a review from a team as a code owner May 4, 2023 13:40
@vepatel vepatel requested review from haywoodsh, ciarams87 and jjngx May 4, 2023 13:40
@vepatel vepatel merged commit 85a353a into main May 4, 2023
@vepatel vepatel deleted the tests/add-retries branch May 4, 2023 14:27
lucacome pushed a commit that referenced this pull request May 4, 2023
lucacome added a commit that referenced this pull request May 4, 2023
… (#3865)

(cherry picked from commit 85a353a)

Co-authored-by: Venktesh Shivam Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants