Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configmap update #379

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Fix configmap update #379

merged 1 commit into from
Sep 27, 2018

Conversation

pleshakov
Copy link
Contributor

The update of the configmap with NGINX customization was not handled
properly by the Ingress Controller:

  • If the user had more than one Ingress resource with TLS termination
    conifgured, the Ingress Controller would crash.
  • If the user had more than one Ingress resource without TLS
    termination, the Ingress Controller would update the config for only
    one Ingress resource.

The bug appeared in a552bd0.

This commit fixes the bug.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@pleshakov
Fix configmap update
62e9a32 
The update of the configmap with NGINX customization was not handled
properly by the Ingress Controller:
- If the user had more than one Ingress resource with TLS termination
conifgured, the Ingress Controller would crash.
- If the user had more than one Ingress resource without TLS
termination, the Ingress Controller would update the config for only
one Ingress resource.

The bug appeared in a552bd0.

This commit fixes the bug.
@pleshakov pleshakov added the bug An issue reporting a potential bug label Sep 27, 2018
isaachawley
isaachawley approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@isaachawley isaachawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pleshakov pleshakov merged commit 79d11e7 into master Sep 27, 2018
@pleshakov pleshakov deleted the fix-update-configmap branch September 27, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@isaachawley isaachawley isaachawley approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleshakov @isaachawley @Dean-Coakley