Swap cpu and memory in HPA template #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3773 +/- ##
=======================================
Coverage 52.38% 52.38%
=======================================
Files 59 59
Lines 16890 16890
=======================================
Hits 8848 8848
Misses 7747 7747
Partials 295 295 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lucacome
reviewed
Apr 17, 2023
lucacome
approved these changes
Apr 18, 2023
lucacome
changed the title
|
This fix follows prior art from here: kubernetes/kubernetes#74099 |
shaun-nx
approved these changes
Apr 19, 2023
lucacome
pushed a commit
that referenced
this pull request
Apr 19, 2023
(cherry picked from commit a10f9da)
lucacome
pushed a commit
that referenced
this pull request
May 3, 2023
(cherry picked from commit a10f9da)
lucacome
added a commit
that referenced
this pull request
May 3, 2023
Swap cpu and memory in HPA template (#3773) (cherry picked from commit a10f9da) Co-authored-by: Bryan Hendryx <[email protected]>
Merged
4 tasks
poblahblahblah
added a commit
to poblahblahblah/sumologic-kubernetes-collection
that referenced
this pull request
Jun 7, 2023
This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD. Originally reported to the ArgoCD project here: argoproj/argo-cd#1079 Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099 Other projects and companies have also addressed this by simply reordering the metrics section: * kubernetes/ingress-nginx#10043 * nginx/kubernetes-ingress#3773 * grafana/helm-charts#758 * open-telemetry/opentelemetry-helm-charts#103 * Nextdoor/k8s-charts#102 Signed-off-by: Patrick O’Brien <[email protected]>
poblahblahblah
added a commit
to poblahblahblah/sumologic-kubernetes-collection
that referenced
this pull request
Jun 12, 2023
This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD. Originally reported to the ArgoCD project here: argoproj/argo-cd#1079 Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099 Other projects and companies have also addressed this by simply reordering the metrics section: * kubernetes/ingress-nginx#10043 * nginx/kubernetes-ingress#3773 * grafana/helm-charts#758 * open-telemetry/opentelemetry-helm-charts#103 * Nextdoor/k8s-charts#102 Signed-off-by: Patrick O’Brien <[email protected]>
swiatekm
pushed a commit
to SumoLogic/sumologic-kubernetes-collection
that referenced
this pull request
Jun 13, 2023
* Reordering HPA metrics to match HPA ordering This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD. Originally reported to the ArgoCD project here: argoproj/argo-cd#1079 Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099 Other projects and companies have also addressed this by simply reordering the metrics section: * kubernetes/ingress-nginx#10043 * nginx/kubernetes-ingress#3773 * grafana/helm-charts#758 * open-telemetry/opentelemetry-helm-charts#103 * Nextdoor/k8s-charts#102 Signed-off-by: Patrick O’Brien <[email protected]> * add CHANGELOG entry --------- Signed-off-by: Patrick O’Brien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There is a kubernetes issue where the cpu and memory get swapped at some point. This make Argocd think the manifest is always out of sync. Swap them here so that Argocd is happy.
#3769
Checklist
Before creating a PR, run through this checklist and mark each as complete.