Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom listen ports document #3715

Merged
merged 13 commits into from
Jun 22, 2023
Merged

Custom listen ports document #3715

merged 13 commits into from
Jun 22, 2023

Conversation

jasonwilliams14
Copy link
Contributor

Proposed changes

This document covers how to customize the listen ports that NGINX Ingress controller listens in, if you opt for something different that 80 and 443.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [ x] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • [x ] I have updated necessary documentation
  • I have rebased my branch onto main
  • [x ] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jasonwilliams14 jasonwilliams14 requested a review from a team as a code owner April 2, 2023 23:12
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 2, 2023
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #3715 (4cbd837) into main (adc42b7) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 4cbd837 differs from pull request most recent head 4fc0274. Consider uploading reports for the commit 4fc0274 to get more accurate results

@@            Coverage Diff             @@
##             main    #3715      +/-   ##
==========================================
- Coverage   51.87%   51.85%   -0.02%     
==========================================
  Files          59       59              
  Lines       16705    16705              
==========================================
- Hits         8665     8663       -2     
- Misses       7743     7745       +2     
  Partials      297      297              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasonwilliams14 jasonwilliams14 added this to the v3.1.1 milestone Apr 26, 2023
@brianehlert brianehlert modified the milestones: v3.1.1, v3.2.0 May 16, 2023
@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking this as "Request changes" to block it from being merged prematurely; there are some small changes I intend to make.

This commit updates many minor issues with the custom listen ports
tutorial, such as the product name and certain formalities around tense
and tone. It also fixes some minor formatting issues related to
linebreaks to improve the readability of the page.
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my changes. The detail, although brief, is in the commit message.

docs/content/tutorials/custom-listen-ports.md Outdated Show resolved Hide resolved
docs/content/tutorials/custom-listen-ports.md Outdated Show resolved Hide resolved
docs/content/tutorials/custom-listen-ports.md Outdated Show resolved Hide resolved
docs/content/tutorials/custom-listen-ports.md Outdated Show resolved Hide resolved
docs/content/tutorials/custom-listen-ports.md Outdated Show resolved Hide resolved
docs/content/tutorials/custom-listen-ports.md Outdated Show resolved Hide resolved
docs/content/tutorials/custom-listen-ports.md Outdated Show resolved Hide resolved
docs/content/tutorials/custom-listen-ports.md Outdated Show resolved Hide resolved
docs/content/tutorials/custom-listen-ports.md Outdated Show resolved Hide resolved
docs/content/tutorials/custom-listen-ports.md Outdated Show resolved Hide resolved
ADubhlaoich and others added 3 commits June 22, 2023 10:52
@jasonwilliams14 jasonwilliams14 enabled auto-merge (squash) June 22, 2023 18:16
@jasonwilliams14 jasonwilliams14 merged commit d39a0a4 into main Jun 22, 2023
@jasonwilliams14 jasonwilliams14 deleted the docs/custom-listen-ports branch June 22, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants