-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom listen ports document #3715
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #3715 +/- ##
==========================================
- Coverage 51.87% 51.85% -0.02%
==========================================
Files 59 59
Lines 16705 16705
==========================================
- Hits 8665 8663 -2
- Misses 7743 7745 +2
Partials 297 297 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Jon Torre <[email protected]> Signed-off-by: Alan Dooley <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm marking this as "Request changes" to block it from being merged prematurely; there are some small changes I intend to make.
This commit updates many minor issues with the custom listen ports tutorial, such as the product name and certain formalities around tense and tone. It also fixes some minor formatting issues related to linebreaks to improve the readability of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my changes. The detail, although brief, is in the commit message.
Co-authored-by: Luca Comellini <[email protected]> Signed-off-by: Alan Dooley <[email protected]>
Co-authored-by: Luca Comellini <[email protected]> Signed-off-by: Jason Williams - NGIИX <[email protected]>
Proposed changes
This document covers how to customize the listen ports that NGINX Ingress controller listens in, if you opt for something different that 80 and 443.
Checklist
Before creating a PR, run through this checklist and mark each as complete.