-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Helm docs #3698
Update Helm docs #3698
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3698 +/- ##
==========================================
- Coverage 52.35% 52.33% -0.03%
==========================================
Files 59 59
Lines 16880 16880
==========================================
- Hits 8838 8834 -4
- Misses 7747 7749 +2
- Partials 295 297 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4d95157
to
dd3a135
Compare
Looks good! Does this mean that we will only have to modify |
dd3a135
to
6dddda0
Compare
@ciarams87 yep! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks grand - though I've noticed a huge amount of instances where NGINX Ingress Controller is listed just as "Ingress Controller", such as in the parameters table.
It's not a blocker of any kind, but updating them for the proper noun would be ideal.
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Luca Comellini <[email protected]>
The Helm docs on the website are out of date. This PR updates the docs and adds to the release scripts to automate the process. The script will copy
deployments/helm-chart/README.md
todocs/content/installation/installation-with-helm.md
and add the necessary tags for Hugo to work.