-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example for the service insight feature (VS and TS) #3691
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #3691 +/- ##
==========================================
+ Coverage 52.33% 52.35% +0.02%
==========================================
Files 59 59
Lines 16880 16880
==========================================
+ Hits 8834 8838 +4
+ Misses 7749 7747 -2
+ Partials 297 295 -2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Venktesh Shivam Patel <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Venktesh Shivam Patel <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall to me. I have a few suggestions for phrasing, otherwise it's grand as-is.
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Venktesh Shivam Patel <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Venktesh Shivam Patel <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Proposed changes
This PR adds examples for the service insight feature (Virtual and Transport Servers)
Checklist
Before creating a PR, run through this checklist and mark each as complete.