Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for the service insight feature (VS and TS) #3691

Merged
merged 24 commits into from
Mar 30, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Mar 27, 2023

Proposed changes

This PR adds examples for the service insight feature (Virtual and Transport Servers)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 27, 2023
@jjngx jjngx added documentation Pull requests/issues for documentation and removed documentation Pull requests/issues for documentation labels Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #3691 (098df99) into main (46ae818) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3691      +/-   ##
==========================================
+ Coverage   52.33%   52.35%   +0.02%     
==========================================
  Files          59       59              
  Lines       16880    16880              
==========================================
+ Hits         8834     8838       +4     
+ Misses       7749     7747       -2     
+ Partials      297      295       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx marked this pull request as ready for review March 28, 2023 11:58
@jjngx jjngx requested a review from a team as a code owner March 28, 2023 11:58
jjngx and others added 2 commits March 28, 2023 13:55
Co-authored-by: Venktesh Shivam Patel <[email protected]>
Signed-off-by: Jakub Jarosz <[email protected]>
Co-authored-by: Venktesh Shivam Patel <[email protected]>
Signed-off-by: Jakub Jarosz <[email protected]>
jjngx and others added 2 commits March 28, 2023 15:02
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall to me. I have a few suggestions for phrasing, otherwise it's grand as-is.

@jjngx jjngx changed the title Example for the service insight feature (VS) Example for the service insight feature (VS and TS) Mar 28, 2023
@jjngx jjngx requested review from ADubhlaoich, vepatel and a team March 29, 2023 14:21
@jjngx jjngx requested a review from a team March 29, 2023 21:25
@jjngx jjngx merged commit 2de1503 into main Mar 30, 2023
@jjngx jjngx deleted the docs/service-insight-example branch March 30, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants