Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build docker steps after tests #3690

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Mar 27, 2023

This re-arranges the steps and moves the build of the docker images after the smoke tests. This way the docker images can only be built after all the tests pass.

@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #3690 (7acb579) into main (e9a6375) will not change coverage.
The diff coverage is n/a.

❗ Current head 7acb579 differs from pull request most recent head 2b3e409. Consider uploading reports for the commit 2b3e409 to get more accurate results

@@           Coverage Diff           @@
##             main    #3690   +/-   ##
=======================================
  Coverage   52.35%   52.35%           
=======================================
  Files          59       59           
  Lines       16880    16880           
=======================================
  Hits         8838     8838           
  Misses       7747     7747           
  Partials      295      295           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome marked this pull request as ready for review March 27, 2023 06:26
@lucacome lucacome requested a review from a team as a code owner March 27, 2023 06:26
@lucacome lucacome self-assigned this Mar 28, 2023

Verified

This commit was signed with the committer’s verified signature.
lucacome Luca Comellini
This move the steps that build the docker images after the smoke tests.
@lucacome lucacome force-pushed the chore/rearrange-workflow branch from 2b3e409 to 2f079a5 Compare March 29, 2023 18:15
@lucacome lucacome merged commit 93e5e2a into main Mar 30, 2023
@lucacome lucacome deleted the chore/rearrange-workflow branch March 30, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants