Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Service Insight docs #3684

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Update Service Insight docs #3684

merged 5 commits into from
Mar 27, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Mar 23, 2023

Proposed changes

This PR updates Service Insight documentation. We make clear that the functionality is available only for NGINX Plus.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx added the documentation Pull requests/issues for documentation label Mar 23, 2023
@jjngx jjngx requested a review from a team as a code owner March 23, 2023 12:16
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #3684 (193b5c0) into main (b18ac8f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3684      +/-   ##
==========================================
+ Coverage   52.35%   52.36%   +0.01%     
==========================================
  Files          59       59              
  Lines       16880    16880              
==========================================
+ Hits         8838     8840       +2     
+ Misses       7747     7745       -2     
  Partials      295      295              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx requested a review from a team March 27, 2023 09:03
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjngx Approved, but could you change the docs: argument in the frontmatter to "DOCS-1180"? I can't seem to make an edit suggestion for any lines in that block.

@jjngx
Copy link
Contributor Author

jjngx commented Mar 27, 2023

@jjngx Approved, but could you change the docs: argument in the frontmatter to "DOCS-1180"? I can't seem to make an edit suggestion for any lines in that block.

Added the new id arg.

@jjngx jjngx closed this Mar 27, 2023
@jjngx jjngx reopened this Mar 27, 2023
@jjngx jjngx merged commit eecc52d into main Mar 27, 2023
@jjngx jjngx deleted the docs/deepinsight branch March 27, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants