-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Service Insight docs #3684
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3684 +/- ##
==========================================
+ Coverage 52.35% 52.36% +0.01%
==========================================
Files 59 59
Lines 16880 16880
==========================================
+ Hits 8838 8840 +2
+ Misses 7747 7745 -2
Partials 295 295 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Shaun <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjngx Approved, but could you change the docs:
argument in the frontmatter to "DOCS-1180"? I can't seem to make an edit suggestion for any lines in that block.
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jakub Jarosz <[email protected]>
Added the new id arg. |
Proposed changes
This PR updates Service Insight documentation. We make clear that the functionality is available only for NGINX Plus.
Checklist
Before creating a PR, run through this checklist and mark each as complete.