Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unwanted chars from label value #3660

Merged
merged 3 commits into from
Mar 20, 2023
Merged

remove unwanted chars from label value #3660

merged 3 commits into from
Mar 20, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Mar 17, 2023

Proposed changes

  • Removes chars ” “, “(” and “)” from nginx-plus version string which were causing regex mismatch error
Labels:           app.kubernetes.io/instance=test-release
                  app.kubernetes.io/name=nginx-ingress
                  app.kubernetes.io/version=main
                  app.nginx.org/version=1.23.2-nginx-plus-r28
                  pod-template-hash=<hash_value>
I0317 13:44:13.496885       1 main.go:234] Kubernetes version: 1.26.1
I0317 13:44:13.505088       1 main.go:380] Using nginx version: nginx/1.23.2 (nginx-plus-r28)
I0317 13:44:13.530882       1 main.go:784] Pod label updated: test-release-nginx-ingress-controller-<.........>

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner March 17, 2023 13:55
@github-actions github-actions bot added the bug An issue reporting a potential bug label Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #3660 (0e53331) into main (cc61703) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3660      +/-   ##
==========================================
- Coverage   52.30%   52.29%   -0.01%     
==========================================
  Files          59       59              
  Lines       16850    16853       +3     
==========================================
  Hits         8813     8813              
- Misses       7740     7743       +3     
  Partials      297      297              
Impacted Files Coverage Δ
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel requested a review from haywoodsh March 20, 2023 10:03
@tomasohaodha tomasohaodha added this to the v3.1.0 milestone Mar 20, 2023
@vepatel vepatel requested a review from jjngx March 20, 2023 11:53
@vepatel vepatel enabled auto-merge (squash) March 20, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants