Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict permissions for Helm in CI #3648

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

lucacome
Copy link
Member

Proposed changes

Looks like packages: write is not enough for the pipeline to overwrite packages, removing it for now to fix the pipeline.

@lucacome lucacome requested a review from a team as a code owner March 14, 2023 21:10
@lucacome lucacome self-assigned this Mar 14, 2023
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 14, 2023
@lucacome lucacome changed the title Remove strict permissions for Helm Remove strict permissions for Helm in CI Mar 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3648 (ac50586) into main (388b730) will increase coverage by 0.02%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3648      +/-   ##
==========================================
+ Coverage   52.21%   52.23%   +0.02%     
==========================================
  Files          59       59              
  Lines       16877    16877              
==========================================
+ Hits         8812     8816       +4     
+ Misses       7768     7766       -2     
+ Partials      297      295       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@lucacome lucacome merged commit 3a18927 into main Mar 14, 2023
@lucacome lucacome deleted the chore/remove-permissions branch March 14, 2023 21:48
@jjngx jjngx requested review from jjngx and removed request for jjngx March 15, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants