Prometheus tls path #3615
Merged
Prometheus tls path #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3615 +/- ##
=======================================
Coverage 52.24% 52.24%
=======================================
Files 59 59
Lines 16873 16873
=======================================
Hits 8816 8816
Misses 7762 7762
Partials 295 295
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6 tasks
jjngx
reviewed
Mar 7, 2023
ciarams87
approved these changes
Mar 8, 2023
jjngx
approved these changes
Mar 8, 2023
jjngx
pushed a commit
that referenced
this pull request
Mar 14, 2023
* Update path to store prometheus secrets * Move DefaultSecretPath const to configurator and add nosec G101 * Fix lint error * Update error check * Update error message * Change function name
lucacome
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update the path that prometheus TLS secrets are written to.
Checklist
Before creating a PR, run through this checklist and mark each as complete.