-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing directory to NGINX App Protect DoS Instructions #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This miniature commit changes the path for the CD command in the second prerequisite of the "Installation with NGINX App Protect DoS" document. A reader with existing knowledge would spot the issue immediately, but one without might be left confused why the subsequent commands fail. Additional, this commit fixes some minor noun issues for the documentation based on the product naming conventions.
github-actions
bot
added
the
documentation
Pull requests/issues for documentation
label
Feb 28, 2023
jjngx
approved these changes
Feb 28, 2023
jjngx
approved these changes
Feb 28, 2023
vepatel
approved these changes
Mar 2, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3605 +/- ##
==========================================
+ Coverage 52.14% 52.21% +0.06%
==========================================
Files 59 59
Lines 16772 16877 +105
==========================================
+ Hits 8746 8812 +66
- Misses 7729 7768 +39
Partials 297 297
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
haywoodsh
approved these changes
Mar 2, 2023
lucacome
reviewed
Mar 10, 2023
lucacome
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This miniature commit changes the path for the CD command in the second prerequisite of the "Installation with NGINX App Protect DoS" document. A reader with existing knowledge would spot the issue immediately, but one without might be left confused why the subsequent commands fail.
Additional, this commit fixes some minor noun issues for the documentation based on the product naming conventions.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.