Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing directory to NGINX App Protect DoS Instructions #3605

Merged
merged 7 commits into from
Mar 15, 2023

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Feb 28, 2023

This miniature commit changes the path for the CD command in the second prerequisite of the "Installation with NGINX App Protect DoS" document. A reader with existing knowledge would spot the issue immediately, but one without might be left confused why the subsequent commands fail.

Additional, this commit fixes some minor noun issues for the documentation based on the product naming conventions.

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This miniature commit changes the path for the CD command in the second
prerequisite of the "Installation with NGINX App Protect DoS" document.
A reader with existing knowledge would spot the issue immediately, but
one without might be left confused why the subsequent commands fail.

Additional, this commit fixes some minor noun issues for the
documentation based on the product naming conventions.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner February 28, 2023 11:50
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Feb 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #3605 (525a3bd) into main (fcf512f) will increase coverage by 0.06%.
The diff coverage is 61.06%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3605      +/-   ##
==========================================
+ Coverage   52.14%   52.21%   +0.06%     
==========================================
  Files          59       59              
  Lines       16772    16877     +105     
==========================================
+ Hits         8746     8812      +66     
- Misses       7729     7768      +39     
  Partials      297      297              
Impacted Files Coverage Δ
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
internal/configs/configurator.go 38.67% <ø> (ø)
internal/configs/version2/http.go 0.00% <ø> (ø)
internal/k8s/controller.go 11.97% <0.00%> (-0.05%) ⬇️
internal/externaldns/sync.go 37.56% <25.00%> (-0.82%) ⬇️
internal/configs/transportserver.go 97.90% <100.00%> (+0.37%) ⬆️
internal/configs/virtualserver.go 95.07% <100.00%> (+<0.01%) ⬆️
pkg/apis/configuration/validation/policy.go 91.41% <100.00%> (+0.24%) ⬆️
...g/apis/configuration/validation/transportserver.go 96.80% <100.00%> (+0.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit 88864c3 into main Mar 15, 2023
@lucacome lucacome deleted the docs/fix-protect-dos-link branch March 15, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants