Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NGINX Ingress controller with OSM tutorial #3592

Merged
merged 31 commits into from
May 2, 2023
Merged

Conversation

jasonwilliams14
Copy link
Contributor

Proposed changes

This document covers how to configure NGINX Ingress controller with Open Service Mesh.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [ x] I have read the CONTRIBUTING doc
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] I have checked that all unit tests pass after adding my changes
  • [ x] I have updated necessary documentation
  • [ x] I have rebased my branch onto main
  • [ x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jasonwilliams14 jasonwilliams14 added the documentation Pull requests/issues for documentation label Feb 24, 2023
@jasonwilliams14 jasonwilliams14 requested a review from a team as a code owner February 24, 2023 22:31
@jasonwilliams14 jasonwilliams14 requested a review from a team February 24, 2023 22:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #3592 (d7044a1) into main (28eee73) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3592   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files          59       59           
  Lines       16902    16902           
=======================================
  Hits         8855     8855           
  Misses       7750     7750           
  Partials      297      297           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to approved, though I have flagged a missing frontmatter block to Jason that has gone missing that will be needed for this doc to be visible.

@jasonwilliams14
Copy link
Contributor Author

Changed to approved, though I have flagged a missing frontmatter block to Jason that has gone missing that will be needed for this doc to be visible.

Should all be fixed now. Updated this morning.

@jasonwilliams14 jasonwilliams14 added this to the v3.1.1 milestone Apr 26, 2023
@jasonwilliams14 jasonwilliams14 merged commit 8e439cb into main May 2, 2023
@jasonwilliams14 jasonwilliams14 deleted the docs/nic-with-osm branch May 2, 2023 21:28
jasonwilliams14 added a commit that referenced this pull request May 2, 2023
lucacome pushed a commit that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants