Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detect-private-key to pre-commit #3589

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

lucacome
Copy link
Member

Adds detect-private-key which detects the presence of private keys.

@lucacome lucacome requested a review from a team as a code owner February 23, 2023 17:55
@lucacome lucacome self-assigned this Feb 23, 2023
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3589 (35c415c) into main (fcf512f) will increase coverage by 0.16%.
The diff coverage is 85.89%.

❗ Current head 35c415c differs from pull request most recent head 50b351b. Consider uploading reports for the commit 50b351b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3589      +/-   ##
==========================================
+ Coverage   52.14%   52.31%   +0.16%     
==========================================
  Files          59       59              
  Lines       16772    16849      +77     
==========================================
+ Hits         8746     8814      +68     
- Misses       7729     7738       +9     
  Partials      297      297              
Impacted Files Coverage Δ
internal/configs/configurator.go 38.67% <ø> (ø)
internal/configs/version2/http.go 0.00% <ø> (ø)
internal/k8s/controller.go 11.97% <0.00%> (-0.05%) ⬇️
internal/configs/transportserver.go 97.90% <100.00%> (+0.37%) ⬆️
internal/configs/virtualserver.go 95.07% <100.00%> (+<0.01%) ⬆️
pkg/apis/configuration/validation/policy.go 91.41% <100.00%> (+0.24%) ⬆️
...g/apis/configuration/validation/transportserver.go 96.80% <100.00%> (+0.17%) ⬆️
...ternal/k8s/appprotect/app_protect_configuration.go 86.74% <0.00%> (+0.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome enabled auto-merge (squash) March 1, 2023 04:02
@lucacome lucacome merged commit 15e418d into main Mar 1, 2023
@lucacome lucacome deleted the chore/pre-commit-detect-private-key branch March 1, 2023 04:10
jjngx pushed a commit that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants