-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push edge Helm Chart to OCI registries #3581
Conversation
fe20717
to
ab24480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much everything I would've commented on is something someone else already covered: looks good to me.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3581 +/- ##
=======================================
Coverage 52.24% 52.25%
=======================================
Files 59 59
Lines 16873 16834 -39
=======================================
- Hits 8816 8797 -19
+ Misses 7762 7740 -22
- Partials 295 297 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There are two outstanding comments from @ciarams87 to update the README that should be change before merging.
Updates the workflow to start using OCI registries for the
edge
Helm Chart.