Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push edge Helm Chart to OCI registries #3581

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Push edge Helm Chart to OCI registries #3581

merged 1 commit into from
Mar 9, 2023

Conversation

lucacome
Copy link
Member

Updates the workflow to start using OCI registries for the edge Helm Chart.

@lucacome lucacome requested a review from a team as a code owner February 22, 2023 03:51
@lucacome lucacome self-assigned this Feb 22, 2023
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart labels Feb 22, 2023
@lucacome lucacome force-pushed the feat/helm-oci branch 2 times, most recently from fe20717 to ab24480 Compare February 22, 2023 03:55
@lucacome lucacome requested a review from a team February 22, 2023 03:56
@lucacome lucacome requested a review from a team February 28, 2023 01:48
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much everything I would've commented on is something someone else already covered: looks good to me.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #3581 (ab24480) into main (96e1fe4) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ab24480 differs from pull request most recent head f840de7. Consider uploading reports for the commit f840de7 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3581   +/-   ##
=======================================
  Coverage   52.24%   52.25%           
=======================================
  Files          59       59           
  Lines       16873    16834   -39     
=======================================
- Hits         8816     8797   -19     
+ Misses       7762     7740   -22     
- Partials      295      297    +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.43% <0.00%> (-0.37%) ⬇️
pkg/apis/configuration/validation/policy.go 91.16% <0.00%> (-0.25%) ⬇️
internal/configs/virtualserver.go 95.07% <0.00%> (-0.01%) ⬇️
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
internal/configs/configurator.go 38.67% <0.00%> (ø)
internal/configs/version2/http.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
There are two outstanding comments from @ciarams87 to update the README that should be change before merging.

@lucacome lucacome merged commit bd9785e into main Mar 9, 2023
@lucacome lucacome deleted the feat/helm-oci branch March 9, 2023 02:26
jjngx pushed a commit that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants