Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure non-ready endpoints are not added to upstreams #3541

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

shaun-nx
Copy link
Contributor

Proposed changes

This change adds a check to ensure non-ready endpoints are not added to our upstreams.

Resolves #3534

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #3541 (aedd8b1) into main (c31629a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3541      +/-   ##
==========================================
+ Coverage   51.98%   51.99%   +0.01%     
==========================================
  Files          60       60              
  Lines       16816    16820       +4     
==========================================
+ Hits         8742     8746       +4     
  Misses       7777     7777              
  Partials      297      297              
Impacted Files Coverage Δ
internal/k8s/controller.go 12.07% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx marked this pull request as ready for review February 10, 2023 12:38
@shaun-nx shaun-nx requested a review from a team as a code owner February 10, 2023 12:38
Copy link
Contributor

@vepatel vepatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shaun-nx shaun-nx merged commit 7190979 into main Feb 10, 2023
@shaun-nx shaun-nx deleted the endpoint-ready branch February 10, 2023 15:48
ciarams87 pushed a commit that referenced this pull request Feb 13, 2023
* Ensure non-ready endpoints are not added to upstreams

* Update variable name
@lucacome lucacome added the bug An issue reporting a potential bug label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nginx-ingress routes traffic to not-ready pods
6 participants