Fix Configurator error check #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
suggested changes
Aug 24, 2018
| t.Errorf("Failed to create a test configurator: %v", err) | ||
| } | ||
| mergeableIngess := createMergeableCafeIngress() | ||
| err = cnf.AddOrUpdateMergableIngress(mergeableIngess) |
There was a problem hiding this comment.
please rename Mergable to Mergeable here and everywhere
Dean-Coakley
force-pushed
the
fix-cfg-err-check
branch
from
eae49b4 to
f658113
Compare
* Added test for UpdateEndpoints * Added test for UpdateEndpointsMergeableIngress
Dean-Coakley
force-pushed
the
fix-cfg-err-check
branch
from
f658113 to
00d452f
Compare
pleshakov
approved these changes
Aug 24, 2018
isserrano
pushed a commit
that referenced
this pull request
Sep 5, 2018
* Fixed unchecked Configurator errors * Added unit tests for AddOrUpdateIngress and AddOrUpdateIngressMergeable * Added unit tests for UpdateEndpoints and UpdateEndpointsMergeableIngress * Fixed mergeableIngress typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.