Add support for prometheus exporter for NGINX #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
enhancement
Dean-Coakley
force-pushed
the
oss-prometheus-exporter
branch
3 times, most recently
from
b0a6c68 to
5b9b8c8
Compare
pleshakov
suggested changes
Aug 28, 2018
There was a problem hiding this comment.
Please see my suggestions.
Additionally:
- Change
Deploys a Prometheus exporter container within the Ingress controller pod. Requires NGINX Plus. controller.nginxplus must be set to true.toDeploys a Prometheus exporter container within the Ingress controller pod. - Rebase against the master
| {{ else }} | ||
| - http://127.0.0.1:8080/stub_status | ||
| {{- end }} | ||
| - -nginx.scrape-uri |
There was a problem hiding this comment.
please don't change the order of the arguments
There was a problem hiding this comment.
example of a problem:
args:
- -web.listen-address
- :9113
- http://127.0.0.1:8080/stub_status
- -nginx.scrape-uri
| - -nginx.scrape-uri | ||
| {{- if .Values.controller.nginxplus }} |
There was a problem hiding this comment.
don't change the other of the arguments. an example of the problem is below:
args:
- -web.listen-address
- :9113
- -nginx.scrape-uri
- -nginx.plus
- http://127.0.0.1:8080/api
* Added oss prometheus deployment manifest * Added oss prometheus daemonset manifest * Updated comparison document * Updated install document
Dean-Coakley
force-pushed
the
oss-prometheus-exporter
branch
from
95a2ff5 to
3b54bd2
Compare
pleshakov
suggested changes
Aug 28, 2018
| - http://127.0.0.1:8080/api | ||
| {{ else }} | ||
| - http://127.0.0.1:8080/stub_status | ||
| {{- end }} | ||
| - -nginx.scrape-uri |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
* Changed prometheus.create note to reflect that nginxplus is no longer required * Reverted helm chart argument order change
Dean-Coakley
force-pushed
the
oss-prometheus-exporter
branch
from
3b54bd2 to
44d024d
Compare
pleshakov
approved these changes
Aug 28, 2018
isserrano
pushed a commit
that referenced
this pull request
Sep 5, 2018
* Added OSS Prometheus deployment manifest * Added OSS Prometheus daemonset manifest * Updated comparison document * Updated install document * Helm: Add OSS Prometheus exporter support * Changed prometheus.create note to reflect that nginxplus is no longer required
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
I have added tests that prove my fix is effective or that my feature works