Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify deep service insight #3453

Merged
merged 2 commits into from
Jan 25, 2023
Merged

clarify deep service insight #3453

merged 2 commits into from
Jan 25, 2023

Conversation

brianehlert
Copy link
Collaborator

@brianehlert brianehlert commented Jan 18, 2023 •
edited by vepatel
Loading

Proposed changes

  • Update web documentation for deep-service-insight feature for TS and VS

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@brianehlert brianehlert requested a review from a team as a code owner January 18, 2023 21:31
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jan 18, 2023
@vepatel
Copy link
Contributor

vepatel commented Jan 19, 2023 •
edited
Loading

Updated PR description, @brianehlert does this needs to go to current release as well? In that case we'll need to cherry-pick this to release-3.0 as docs are published from there not main

@vepatel
Copy link
Contributor

vepatel commented Jan 19, 2023

Adding @jjngx for review

@vepatel vepatel requested a review from jjngx January 19, 2023 13:17
@brianehlert
Copy link
Collaborator Author

Updated PR description, @brianehlert does this needs to go to current release as well? In that case we'll need to cherry-pick this to release-3.0 as docs are published from there not main

We should be able to pick this up with a patch. Track for that.

@lucacome lucacome merged commit 01d817f into main Jan 25, 2023
@lucacome lucacome deleted the clarify_service_insight branch January 25, 2023 18:36
lucacome pushed a commit that referenced this pull request Jan 25, 2023
@brianehlert @lucacome
Clarify deep service insight (#3453)
119fc48 
(cherry picked from commit 01d817f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx shaun-nx approved these changes

@jjngx jjngx jjngx approved these changes

@vepatel vepatel vepatel approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

@lucacome lucacome Awaiting requested review from lucacome lucacome was automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@brianehlert @vepatel @haywoodsh @ciarams87 @jjngx @shaun-nx @lucacome