-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable keepalive-time for healthchecks in VS and VSR #3451
Conversation
tests/data/virtual-server-upstream-options/plus-virtual-server-with-invalid-keys-openapi.yaml
Outdated
Show resolved
Hide resolved
7a5424d
to
8f5d4fb
Compare
8f5d4fb
to
c649fea
Compare
c649fea
to
9443b22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good. We can set a default between 30-60 seconds.
we can also give customers to disable entirely if they choose to.
it is a great new feature that will improve performance and HC effectiveness.
9443b22
to
d5209b6
Compare
d5209b6
to
718fa42
Compare
Codecov Report
@@ Coverage Diff @@
## main #3451 +/- ##
==========================================
+ Coverage 51.95% 51.99% +0.03%
==========================================
Files 60 60
Lines 16806 16811 +5
==========================================
+ Hits 8732 8741 +9
+ Misses 7777 7775 -2
+ Partials 297 295 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Proposed changes
Keepalive connections for health checks – The new keepalive_time parameter to the HTTP health_check directive enables keepalive connections for health checks and sets their lifetime. Establishing new connections is computationally expensive, so reusing connections can reduce CPU usage considerably when there are large numbers of upstream servers.
Checklist
Before creating a PR, run through this checklist and mark each as complete.