Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of map-hash-bucket-size and map-hash-max-size directives #3274

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Nov 18, 2022

Proposed changes

This change allows for configuration of the map-hash-bucket-size and map-hash-max-size directives.
Both of these directives are set with default values and are configurable using a ConfigMap.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 18, 2022
@shaun-nx shaun-nx marked this pull request as ready for review November 18, 2022 13:59
@shaun-nx shaun-nx requested a review from a team as a code owner November 18, 2022 13:59
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff 👍🏻

@shaun-nx shaun-nx merged commit 9d94d45 into main Nov 23, 2022
@shaun-nx shaun-nx deleted the long-hostname branch November 23, 2022 14:12
@brianehlert brianehlert linked an issue Nov 23, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transportserver resource breaks with a long FQDN host value.
3 participants