Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep service insight endpoint #3261

Merged
merged 71 commits into from
Dec 5, 2022
Merged
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
c2ed0e6
poc for healthcheck inside NIC
haywoodsh Nov 6, 2022
b759a84
add listener.go
haywoodsh Nov 9, 2022
ea63d10
Add changes discussed in the meeting
jjngx Nov 9, 2022
3405d0a
Add initial implementation of the server
jjngx Nov 9, 2022
e0bebd0
Minor syntax update
jjngx Nov 9, 2022
852e577
Add a web server and a router
jjngx Nov 10, 2022
482a673
Refactor, handle err, simplify
jjngx Nov 10, 2022
b7257d1
Updated docs
jjngx Nov 10, 2022
dc5050c
Update data type expected by log message
jjngx Nov 10, 2022
0877b5a
Add TLS support for the healthcheck server
jjngx Nov 11, 2022
b2f1b91
Fix typos
jjngx Nov 11, 2022
f08179c
Add placeholders for server tests
jjngx Nov 11, 2022
2c0fc9a
Check if hostname exist and handle http 404
jjngx Nov 11, 2022
fa830da
Update url path to include 'probe'
jjngx Nov 11, 2022
ae81944
Refactor handler, add tests
jjngx Nov 12, 2022
8f56d3f
create flags for health probe
haywoodsh Nov 14, 2022
65eff0b
Handle errors from starting servers
jjngx Nov 14, 2022
1938451
Support min TLS v1.0
jjngx Nov 14, 2022
b9e2d5f
Update min TLS version to 1.2
jjngx Nov 15, 2022
3ee5480
Simplify package structure
jjngx Nov 15, 2022
dcebe1c
Remove double import
jjngx Nov 15, 2022
6ba4114
Round flow to the left
jjngx Nov 15, 2022
d4fa8fb
Sanitize hostname param
jjngx Nov 16, 2022
9c01b84
Use different var name for sanitized input
jjngx Nov 16, 2022
b4270c0
Sanitize params
jjngx Nov 17, 2022
4d8e455
Add a middleware for hostname length validation
jjngx Nov 17, 2022
04a6b61
Remove unused dependency
jjngx Nov 17, 2022
ae9c6d6
Fix linter issues
jjngx Nov 17, 2022
a7ea187
Simplify healthcheck server and tests
jjngx Nov 21, 2022
1f4575b
Merge branch 'main' into feat/deep-service-insight-endpoint
jjngx Nov 21, 2022
3982350
Update dependencies
jjngx Nov 21, 2022
0b33646
Remove hostname validation
jjngx Nov 23, 2022
c146e69
Rename healthcheck to service insight
jjngx Nov 23, 2022
bab4d7d
Update docs for Service Insight feature
jjngx Nov 23, 2022
2c9c40e
Add log info staring healthcheck
jjngx Nov 24, 2022
fb74e12
Use more meaningful var name
jjngx Nov 24, 2022
aca4d38
Update log verbosity
jjngx Nov 24, 2022
2a3fc28
Initial integration test for healthcheck service
jjngx Nov 25, 2022
18cad3a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 25, 2022
5604792
add service-insight port to loadbalancer svc yaml
vepatel Nov 28, 2022
094d93f
Use TLS v1.0 as a min version
jjngx Nov 28, 2022
9ffc97d
mark test as N+ only
vepatel Nov 28, 2022
df4ae66
Update err message
jjngx Nov 28, 2022
5d769a2
Merge branch 'main' into feat/deep-service-insight-endpoint
jjngx Nov 28, 2022
38d9781
Add service insight options to IC manifest
jjngx Nov 29, 2022
384cc55
Add service-insight documentation page
jjngx Nov 29, 2022
91a45d5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 29, 2022
e6defb3
Update Helm chart for Service Insight
jjngx Nov 29, 2022
682026f
Apply PR feedback
jjngx Nov 29, 2022
9727bb5
Merge branch 'main' into feat/deep-service-insight-endpoint
jjngx Nov 29, 2022
d93c007
Add test for https endpoint
vepatel Nov 29, 2022
ab945e8
add test for replica change
vepatel Nov 30, 2022
6c04db4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 30, 2022
34b9a8b
Merge branch 'main' into feat/deep-service-insight-endpoint
jjngx Nov 30, 2022
2387e1d
Update docs/content/logging-and-monitoring/service-insight.md
jjngx Dec 1, 2022
1a449fc
Update docs/content/configuration/global-configuration/command-line-a…
jjngx Dec 1, 2022
167fbfc
Update docs/content/logging-and-monitoring/service-insight.md
jjngx Dec 1, 2022
923ccb1
Update docs/content/logging-and-monitoring/service-insight.md
jjngx Dec 1, 2022
46ac908
Update docs/content/logging-and-monitoring/service-insight.md
jjngx Dec 1, 2022
9d08f94
Update docs/content/logging-and-monitoring/service-insight.md
jjngx Dec 1, 2022
ee0abb0
Update docs/content/logging-and-monitoring/service-insight.md
jjngx Dec 1, 2022
bd25635
Update docs/content/configuration/global-configuration/command-line-a…
jjngx Dec 1, 2022
0aafb41
Update docs/content/configuration/global-configuration/command-line-a…
jjngx Dec 1, 2022
2075150
Update docs/content/configuration/global-configuration/command-line-a…
jjngx Dec 1, 2022
86903f4
Update docs/content/logging-and-monitoring/service-insight.md
jjngx Dec 1, 2022
faf8245
Update docs/content/logging-and-monitoring/service-insight.md
jjngx Dec 1, 2022
aec41bc
Increase wait time in integration test
jjngx Dec 2, 2022
cbf43e6
Update deployments/helm-chart/values.yaml
jjngx Dec 2, 2022
8ba1029
add conditional check on waitTime for api response
vepatel Dec 2, 2022
48b3d72
Add docs for Helm installation
jjngx Dec 5, 2022
1ecc63e
Merge branch 'main' into feat/deep-service-insight-endpoint
jjngx Dec 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Sanitize hostname param
  • Loading branch information
jjngx committed Nov 16, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit d4fa8fb1570434e794f3ba9fd34d7e4d38734a92
2 changes: 1 addition & 1 deletion internal/healthcheck/healthcheck.go
Original file line number Diff line number Diff line change
@@ -128,7 +128,7 @@ type HealthHandler struct {

// Retrieve finds health stats for the host identified by a hostname in the request URL.
func (h *HealthHandler) Retrieve(w http.ResponseWriter, r *http.Request) {
hostname := chi.URLParam(r, "hostname")
hostname := strings.TrimSpace(chi.URLParam(r, "hostname"))

upstreamNames := h.UpstreamsForHost(hostname)
if len(upstreamNames) == 0 {