Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use latest tag for AWS images #3125

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Don't use latest tag for AWS images #3125

merged 2 commits into from
Oct 4, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Oct 4, 2022

AWS doesn't accept the tag latest and causes the pipeline to throw an error.

@lucacome lucacome requested a review from a team October 4, 2022 00:36
@lucacome lucacome self-assigned this Oct 4, 2022
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 4, 2022
@lucacome lucacome requested a review from ciarams87 October 4, 2022 00:37
@lucacome lucacome changed the title Remove latest tag from AWS images Don't use latest tag for AWS images Oct 4, 2022
AWS doesn't accept the tag `latest` and causes the pipeline to throw an error.
@lucacome lucacome requested a review from vepatel October 4, 2022 06:59
@codecov-commenter
Copy link

Codecov Report

Merging #3125 (f27f574) into main (28b4a63) will not change coverage.
The diff coverage is n/a.

❗ Current head f27f574 differs from pull request most recent head 127a3f7. Consider uploading reports for the commit 127a3f7 to get more accurate results

@@           Coverage Diff           @@
##             main    #3125   +/-   ##
=======================================
  Coverage   52.52%   52.52%           
=======================================
  Files          58       58           
  Lines       16069    16069           
=======================================
  Hits         8440     8440           
  Misses       7351     7351           
  Partials      278      278           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome requested a review from tomasohaodha October 4, 2022 07:20
@lucacome lucacome merged commit 39eefc4 into main Oct 4, 2022
@lucacome lucacome deleted the chore/aws-latest branch October 4, 2022 07:49
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
AWS doesn't accept the tag `latest` and causes the pipeline to throw an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants