-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make target for running staticcheck locally #3110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golangci-lint is already running staticcheck
, what is the difference with this?
staticcheck in golangci-lint is a subset of checks implemented by staticcheck project (binary). more info here |
Codecov Report
@@ Coverage Diff @@
## main #3110 +/- ##
==========================================
- Coverage 52.56% 52.54% -0.02%
==========================================
Files 58 58
Lines 16069 16069
==========================================
- Hits 8446 8444 -2
- Misses 7347 7349 +2
Partials 276 276
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Proposed changes
This PR adds a make target
staticcheck
that runs staticcheck linter locally.Checklist
Before creating a PR, run through this checklist and mark each as complete.