Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AppProtect warning message #3096

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Change AppProtect warning message #3096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad8decd
Change AppProtect warning message
vepatel Sep 26, 2022
ee26e53
run linter
vepatel Sep 26, 2022
2c50c8d
Merge branch 'main' into tests/fix-appprotect-message
vepatel Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/suite/test_app_protect_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,14 +390,16 @@ def test_ap_multi_sec_logs(
assert_invalid_responses(response)
# check logs in dest. #1 i.e. syslog server #1
assert (
'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS)"' in log_contents
'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"'
in log_contents
and 'severity="Critical"' in log_contents
and 'request_status="blocked"' in log_contents
and 'outcome="REJECTED"' in log_contents
)
# check logs in dest. #2 i.e. syslog server #2
assert (
'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS)"' in log2_contents
'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"'
in log2_contents
and 'severity="Critical"' in log2_contents
and 'request_status="blocked"' in log2_contents
and 'outcome="REJECTED"' in log2_contents
Expand Down
5 changes: 4 additions & 1 deletion tests/suite/test_app_protect_waf_policies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,10 @@ def test_ap_waf_policy_multi_logs(

assert_invalid_responses(response)

assert f'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS)"' in log_contents
assert (
f'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"'
in log_contents
)
assert f'severity="Critical"' in log_contents
assert f'request_status="blocked"' in log_contents
assert f'outcome="REJECTED"' in log_contents
Expand Down