-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise path validation #3094
Optimise path validation #3094
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3094 +/- ##
==========================================
+ Coverage 52.41% 52.52% +0.10%
==========================================
Files 58 58
Lines 15997 16033 +36
==========================================
+ Hits 8385 8421 +36
Misses 7336 7336
Partials 276 276
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9c1205d
to
ff9df8c
Compare
464a2f9
to
bda9f45
Compare
de28c8e
to
f661486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
* update path validation
Why consider paths like "/root", "/etc/nginx/secrets", etc... as invalids? This makes this ingress unusable in a project that has a "/root" path on it (that can't change the name, because it is a big project running for several years). I was using normally before this PR and now can't update the cluster just because of this strange validation. If a path passes the official RFC, it should be valid. My scenario have a "/root" that has nothing to do with Linux "/root" folder (if that is the intention of the validation). Other validations seems useful, but this one is just nonsense (with all the respect). |
Proposed changes
Optimize path validation and add test cases.
Checklist
Before creating a PR, run through this checklist and mark each as complete.